Provide an option to run commands via sh -c

The new flag "shell" instructs pies to run the command marked with it
as '/bin/sh -c $command'. Alternative shell can be supplied ising the
'program' statement.

This is useful if the command line uses shell-specific features (command
or variable expansion, redirection, pipes, etc.)

This commit also fixes a bug in the 'env' statement handling: a single
argument with embedded whitespaces was undergoing word splitting and
thus incorrectly handled as multiple arguments.

* NEWS: Document changes.
* doc/pies.texi: Likewise.
* src/comp.c (component_free): Free command.
(component_finish): Split command into argv/argc as directed by the
CF_SHELL flag.
* src/pies.c (_cb_command): Remove. Functionality moved to
component_finish().
(_cb_env): Bugfix. Don't split arguments.
* src/pies.h (CF_SHELL): New flag.
(component) <command>: New member.

* tests/Makefile.am: Add new tests.
* tests/testsuite.at: Add new tests.
* tests/aux/respawn: Change default timeout to 1 second.
* tests/respawn.at: Minor change.
* tests/shell.at: New test.

1 files changed, 7 insertions, 41 deletions

diff --git a/src/pies.c b/src/pies.c
index 98488a6..6105ae6 100644
--- a/src/pies.c
+++ b/src/pies.c
@@ -524,37 +524,6 @@ config_array_to_argv (grecs_value_t *val, grecs_locus_t *locus, size_t *pargc)
 }
 
 static int
-_cb_command (enum grecs_callback_command cmd,
-	      grecs_locus_t *locus,
-	      void *varptr, grecs_value_t *value, void *cb_data)
-{
-  struct component *comp = varptr;
-  struct wordsplit ws;
-
-  switch (value->type)
-    {
-    case GRECS_TYPE_STRING:
-      if (wordsplit (value->v.string, &ws, WRDSF_DEFFLAGS))
-	{
-	  grecs_error (locus, 0, "wordsplit: %s", strerror (errno));
-	  return 1;
-	}
-      wordsplit_get_words (&ws, &comp->argc, &comp->argv);
-      wordsplit_free (&ws);
-      break;
-
-    case GRECS_TYPE_ARRAY:
-      comp->argv = config_array_to_argv (value, locus, &comp->argc);
-      break;
-
-    case GRECS_TYPE_LIST:
-      grecs_error (locus, 0, _("unexpected list"));
-      return 1;
-    }
-  return 0;
-}
-
-static int
 _cb_umask (enum grecs_callback_command cmd,
 	   grecs_locus_t *locus,
 	   void *varptr, grecs_value_t *value, void *cb_data)
@@ -589,13 +558,9 @@ _cb_env (enum grecs_callback_command cmd,
   switch (value->type)
     {
     case GRECS_TYPE_STRING:
-      if (wordsplit (value->v.string, &ws, WRDSF_DEFFLAGS))
-	{
-	  grecs_error (locus, 0, "wordsplit: %s", strerror (errno));
-	  return 1;
-	}
-      wordsplit_get_words (&ws, &argc, &argv);
-      wordsplit_free (&ws);
+      argv = grecs_calloc (2, sizeof (argv[0]));
+      argv[0] = grecs_strdup (value->v.string);
+      argv[1] = NULL;
       break;
 
     case GRECS_TYPE_ARRAY:
@@ -887,6 +852,7 @@ str_to_cf (const char *string, int *flags)
     { "resolve", CF_RESOLVE },
     { "siggroup", CF_SIGGROUP },
     { "nullinput", CF_NULLINPUT },
+    { "shell", CF_SHELL },
     { NULL }
   };
 
@@ -1014,9 +980,9 @@ struct grecs_keyword component_keywords[] = {
    NULL,
    N_("Command line."),
    grecs_type_string, GRECS_DFLT,
-   NULL, 0,
-   _cb_command,
-   },
+   NULL, offsetof (struct component, command),
+   NULL,
+  },
   {"prerequisites",
    N_("list"),
    N_("List of prerequisites."),