aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorSergey Poznyakoff <gray@gnu.org>2015-01-22 00:44:27 +0200
committerSergey Poznyakoff <gray@gnu.org>2015-01-22 00:44:27 +0200
commit0c7bb2d5cb81eb6077a8907ce2049278fb8e47ce (patch)
tree7392dad30ac09b3ff32bfb2882710b5117fdde35 /src
parent03c5b9aac73c6a70b1c67f467bbd484d2a532f10 (diff)
downloadeclat-0c7bb2d5cb81eb6077a8907ce2049278fb8e47ce.tar.gz
eclat-0c7bb2d5cb81eb6077a8907ce2049278fb8e47ce.tar.bz2
authentication-provider instance-store does not require role name argument
* NEWS: Update. * doc/eclat.conf.5: Update. * lib/Makefile.am: Add new sources. * lib/istore.c: New file. * lib/path.c: New file. * lib/libeclat.h (path_concat) (instance_store_curl_new) (instance_store_read): New protos. * src/config.c (cb_authentication_provider): second argument is optional for instance-store type. New compound statement: instance-store. * src/eclat.h (instance_store_base_url) (instance_store_port,instance_store_document_path): (instance_store_credentials_path): New externs. * src/ispeek.c: Rewrite using new functions. * src/util.c: Likewise.
Diffstat (limited to 'src')
-rw-r--r--src/config.c72
-rw-r--r--src/eclat.h5
-rw-r--r--src/ispeek.c92
-rw-r--r--src/util.c141
4 files changed, 144 insertions, 166 deletions
diff --git a/src/config.c b/src/config.c
index d3c8a66..ec676b7 100644
--- a/src/config.c
+++ b/src/config.c
@@ -261,37 +261,55 @@ cb_authentication_provider(enum grecs_callback_command cmd,
grecs_value_t *value,
void *cb_data)
{
- char *s;
+ char *type;
+ char *arg = NULL;
if (cmd != grecs_callback_set_value) {
grecs_error(locus, 0, "Unexpected block statement");
return 1;
}
- if (!value || value->type != GRECS_TYPE_ARRAY || value->v.arg.c != 2) {
- grecs_error(locus, 0, "expected two values");
- return 1;
- }
- if (value->v.arg.v[0]->type != GRECS_TYPE_STRING) {
- grecs_error(&value->v.arg.v[0]->locus, 0,
- "first argument not a string");
- return 1;
- }
- if (value->v.arg.v[1]->type != GRECS_TYPE_STRING) {
- grecs_error(&value->v.arg.v[1]->locus, 0,
- "second argument not a string");
+ if (!value) {
+ grecs_error(locus, 0, "expected one to two values");
return 1;
}
+ if (value->type == GRECS_TYPE_ARRAY) {
+ if (value->v.arg.c != 2) {
+ grecs_error(locus, 0, "expected one to two values");
+ return 1;
+ }
+ if (value->v.arg.v[0]->type != GRECS_TYPE_STRING) {
+ grecs_error(&value->v.arg.v[0]->locus, 0,
+ "first argument not a string");
+ return 1;
+ }
+ if (value->v.arg.v[1]->type != GRECS_TYPE_STRING) {
+ grecs_error(&value->v.arg.v[1]->locus, 0,
+ "second argument not a string");
+ return 1;
+ }
- s = value->v.arg.v[0]->v.string;
+ type = value->v.arg.v[0]->v.string;
+ arg = value->v.arg.v[1]->v.string;
+ } else if (value->type == GRECS_TYPE_STRING) {
+ type = value->v.string;
+ arg = NULL;
+ }
- if (strcmp(s, "file") == 0) {
+ if (strcmp(type, "file") == 0) {
+ if (arg) {
+ grecs_error(locus, 0, "requered argument missing");
+ return 1;
+ }
authentication_provider = authp_file;
free(access_file_name);
access_file_name = grecs_strdup(value->v.arg.v[1]->v.string);
- } else if (strcmp(s, "instance-store") == 0) {
+ } else if (strcmp(type, "instance-store") == 0) {
authentication_provider = authp_instance;
free(access_key);
- access_key = grecs_strdup(value->v.arg.v[1]->v.string);
+ if (arg)
+ access_key = grecs_strdup(arg);
+ else
+ access_key = NULL;
} else {
grecs_error(&value->locus, 0, "unknown provider");
}
@@ -320,6 +338,22 @@ cb_access_file(enum grecs_callback_command cmd,
return 0;
}
+static struct grecs_keyword instance_store_kw[] = {
+ { "base-url", "URL",
+ "Base URL of the instance store",
+ grecs_type_string, GRECS_DFLT, &instance_store_base_url },
+ { "port", "NUMBER",
+ "Port number",
+ grecs_type_ushort, GRECS_DFLT, &instance_store_port },
+ { "document-path", "PATH",
+ "Path to the instance identity document file",
+ grecs_type_ushort, GRECS_DFLT, &instance_store_document_path },
+ { "credentials-path", "PATH",
+ "Path to the instance store credentials directory",
+ grecs_type_ushort, GRECS_DFLT, &instance_store_credentials_path },
+ { NULL }
+};
+
static struct grecs_keyword eclat_kw[] = {
{ "default-endpoint", "hostname",
"Set default EC2 endpoint",
@@ -370,6 +404,10 @@ static struct grecs_keyword eclat_kw[] = {
{ "translate", NULL,
"Use ID translation by default",
grecs_type_bool, GRECS_DFLT, &translation_enabled },
+ { "instance-store", NULL,
+ "Configure instance store parameters",
+ grecs_type_section, GRECS_DFLT,
+ NULL, 0, NULL, NULL, instance_store_kw },
{ NULL }
};
diff --git a/src/eclat.h b/src/eclat.h
index e5a2c21..d83b8fa 100644
--- a/src/eclat.h
+++ b/src/eclat.h
@@ -64,6 +64,11 @@ extern int translation_enabled;
extern char *custom_map;
extern enum eclat_confirm_mode confirm_mode;
+extern char *instance_store_base_url;
+extern unsigned short instance_store_port;
+extern char *instance_store_document_path;
+extern char *instance_store_credentials_path;
+
typedef int (*config_finish_hook_t) (void*);
void add_config_finish_hook(config_finish_hook_t fun, void *data);
diff --git a/src/ispeek.c b/src/ispeek.c
index 95e1a4c..2c518cb 100644
--- a/src/ispeek.c
+++ b/src/ispeek.c
@@ -40,81 +40,26 @@ char *delim = ":";
int recursive;
long port;
-static char *
-make_url(const char *url, const char *path)
-{
- char *p;
- size_t len = strlen(url);
-
- while (len > 0 && url[len-1] == '/')
- --len;
-
- while (*path == '/')
- ++path;
-
- p = grecs_malloc(len + strlen(path) + 2);
- memcpy(p, url, len);
- p[len++] = '/';
- strcpy(p + len, path);
- return p;
-}
-
-static size_t
-acc_cb(void *ptr, size_t size, size_t nmemb, void *data)
-{
- size_t realsize = size * nmemb;
- struct grecs_txtacc *acc = data;
-
- grecs_txtacc_grow(acc, ptr, realsize);
-
- return realsize;
-}
+struct closure {
+ char *text;
+ CURL *curl;
+ struct grecs_txtacc *acc;
+ char **argv;
+};
static char *
read_from(const char *path, CURL *curl, struct grecs_txtacc *acc)
{
- CURLcode res;
- long http_resp;
- char *text;
char *url;
-
- url = make_url(base_url, path);
- curl_easy_setopt(curl, CURLOPT_URL, url);
-
- res = curl_easy_perform(curl);
- if (res != CURLE_OK)
- die(EX_UNAVAILABLE, "CURL: %s", curl_easy_strerror(res));
-
- res = curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &http_resp);
- if (res != CURLE_OK)
- die(EX_UNAVAILABLE, "CURL: %s", curl_easy_strerror(res));
-
- grecs_txtacc_grow_char(acc, 0);
- text = grecs_txtacc_finish(acc, 0);
- switch (http_resp) {
- case 200:
- break;
+ url = path_concat(base_url, path);
- case 404:
- grecs_txtacc_free_string(acc, text);
+ if (instance_store_read(url, curl))
return NULL;
-
- default:
- die(EX_UNAVAILABLE, "CURL: got response %3d, url %s",
- http_resp, url);
- }
- free(url);
- return text;
+ grecs_txtacc_grow_char(acc, 0);
+ return grecs_txtacc_finish(acc, 0);
}
-struct closure {
- char *text;
- CURL *curl;
- struct grecs_txtacc *acc;
- char **argv;
-};
-
static void print_dir(const char *path, struct closure *cl);
static void
@@ -149,11 +94,11 @@ print_dir(const char *path, struct closure *cl)
printf("%s%s\n", path, ws.ws_wordv[i]);
if (recursive) {
if (isroot) {
- char *p = make_url(path, ws.ws_wordv[i]);
- url = make_url(p, "/");
+ char *p = path_concat(path, ws.ws_wordv[i]);
+ url = path_concat(p, "/");
free(p);
} else if (ws.ws_wordv[i][strlen(ws.ws_wordv[i]) - 1] == '/') {
- url = make_url(path, ws.ws_wordv[i]);
+ url = path_concat(path, ws.ws_wordv[i]);
} else
continue;
list(url, cl);
@@ -245,18 +190,11 @@ ispeek_do(char **argv)
const char *path = *argv++;
char *text;
- curl = curl_easy_init();
- if (!curl)
- die(EX_UNAVAILABLE, "curl_easy_init failed");
+ acc = grecs_txtacc_create();
+ curl = instance_store_curl_new(acc);
if (port)
curl_easy_setopt(curl, CURLOPT_PORT, (long) port);
- curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);
eclat_set_curl_trace(curl, debug_level(0));
-
- acc = grecs_txtacc_create();
-
- curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, acc_cb);
- curl_easy_setopt(curl, CURLOPT_WRITEDATA, acc);
text = read_from(path, curl, acc);
if (text) {
diff --git a/src/util.c b/src/util.c
index 88e3465..9220a11 100644
--- a/src/util.c
+++ b/src/util.c
@@ -367,117 +367,113 @@ canonattrname(char **attrs, const char *arg, char *delim, size_t *plen)
}
return NULL;
}
-
-static size_t
-get_meta_data_cb(void *ptr, size_t size, size_t nmemb, void *data)
-{
- size_t realsize = size * nmemb;
- char *v;
-
- if (debug_level(ECLAT_DEBCAT_MAIN) >= 10)
- debug_printf("Got %*.*s", realsize, realsize, ptr);
-
- v = grecs_malloc(realsize + 1);
- memcpy(v, ptr, realsize);
- v[realsize] = 0;
- *(char**)data = v;
- return realsize;
-}
-
-char *
-eclat_get_instance_meta_data(char *url)
+
+char *instance_store_base_url = "http://169.254.169.254/latest";
+unsigned short instance_store_port;
+char *instance_store_document_path = "dynamic/instance-identity/document";
+char *instance_store_credentials_path = "meta-data/iam/security-credentials";
+
+static CURL *
+get_curl(struct grecs_txtacc *acc)
{
CURLcode res;
- CURL *curl = curl_easy_init();
- char *retval = NULL;
- long http_resp;
-
- if (!curl)
- die(EX_UNAVAILABLE, "curl_easy_init failed");
+ CURL *curl = instance_store_curl_new(acc);
- if (debug_level(ECLAT_DEBCAT_CURL)) {
- curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
- if (debug_level(ECLAT_DEBCAT_CURL) > 1)
- curl_easy_setopt(curl, CURLOPT_DEBUGFUNCTION,
- eclat_trace_fun);
- }
-
- curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, get_meta_data_cb);
- curl_easy_setopt(curl, CURLOPT_WRITEDATA, &retval);
-
- curl_easy_setopt(curl, CURLOPT_URL, url);
-
- res = curl_easy_perform(curl);
-
- if (res != CURLE_OK)
- die(EX_UNAVAILABLE, "CURL: %s", curl_easy_strerror(res));
-
- res = curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &http_resp);
- if (res != CURLE_OK)
- die(EX_UNAVAILABLE, "CURL: %s", curl_easy_strerror(res));
-
- if (http_resp != 200)
- die(EX_UNAVAILABLE, "CURL: unexpected error code %3ld", res);
-
- curl_easy_cleanup(curl);
-
- return retval;
+ eclat_set_curl_trace(curl, debug_level(ECLAT_DEBCAT_CURL));
+ curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);
+ if (instance_store_port)
+ curl_easy_setopt(curl, CURLOPT_PORT,
+ (long) instance_store_port);
+ return curl;
}
-#define URL_INST_DOCUMENT\
- "http://169.254.169.254/latest/dynamic/instance-identity/document"
-
char *
eclat_get_instance_zone()
{
char *doc;
struct json_object *obj, *p;
char *retval = NULL;
-
- doc = eclat_get_instance_meta_data(URL_INST_DOCUMENT);
-
+ CURL *curl;
+ char *url;
+ struct grecs_txtacc *acc;
+
+ acc = grecs_txtacc_create();
+ curl = get_curl(acc);
+ url = path_concat(instance_store_base_url,
+ instance_store_document_path);
+ if (instance_store_read(url, curl))
+ doc = NULL;
+ else {
+ grecs_txtacc_grow_char(acc, 0);
+ doc = grecs_txtacc_finish(acc, 0);
+ }
+ free(url);
+ curl_easy_cleanup(curl);
+ if (!doc)
+ return NULL;
obj = json_parse_string(doc, strlen(doc));
if (!obj)
die(EX_DATAERR,
"%s: near %s",
json_err_diag,
json_err_ptr);
- free(doc);
p = json_object_lookup(obj, "region");
if (p && p->type == json_string)
retval = grecs_strdup(p->v.s);
+ grecs_txtacc_free(acc);
json_object_free(obj);
return retval;
}
-#define URL_INST_CREDS\
- "http://169.254.169.254/latest/meta-data/iam/security-credentials/"
-
void
eclat_get_instance_creds(char *id, char **access_key_ptr, char **secret_key_ptr,
char **token_ptr)
{
+ CURL *curl;
char *url = NULL;
- size_t s;
+ char *s;
char *doc;
struct json_object *obj, *p;
int err = 0;
-
- s = sizeof(URL_INST_CREDS) + strlen(id);
- url = grecs_malloc(s);
- strcpy(url, URL_INST_CREDS);
- strcat(url, id);
-
- doc = eclat_get_instance_meta_data(url);
-
+ struct grecs_txtacc *acc;
+
+ acc = grecs_txtacc_create();
+ curl = get_curl(acc);
+ url = path_concat(instance_store_base_url,
+ instance_store_credentials_path);
+ if (id) {
+ s = url;
+ url = path_concat(s, id);
+ free(s);
+ }
+ if (instance_store_read(url, curl))
+ die(EX_UNAVAILABLE, "url %s: not found ", url);
+ else {
+ grecs_txtacc_grow_char(acc, 0);
+ doc = grecs_txtacc_finish(acc, 0);
+ }
+ if (!id) {
+ size_t len = strcspn(doc, "\r\n");
+ doc[len] = 0;
+ s = url;
+ url = path_concat(s, doc);
+ free(s);
+ if (instance_store_read(url, curl))
+ die(EX_UNAVAILABLE, "url %s: not found ", url);
+ else {
+ grecs_txtacc_grow_char(acc, 0);
+ doc = grecs_txtacc_finish(acc, 0);
+ }
+ }
+ free(url);
+
obj = json_parse_string(doc, strlen(doc));
if (!obj)
die(EX_DATAERR,
"%s: near %s",
json_err_diag,
json_err_ptr);
- free(doc);
p = json_object_lookup(obj, "AccessKeyId");
if (p && p->type == json_string)
@@ -497,6 +493,7 @@ eclat_get_instance_creds(char *id, char **access_key_ptr, char **secret_key_ptr,
else
err = 1;
+ grecs_txtacc_free(acc);
json_object_free(obj);
if (err)

Return to:

Send suggestions and report system problems to the System administrator.