summaryrefslogtreecommitdiffabout
path: root/src/binlog.c
authorSergey Poznyakoff <gray@gnu.org.ua>2013-10-13 10:39:50 (GMT)
committer Sergey Poznyakoff <gray@gnu.org.ua>2013-10-13 10:56:37 (GMT)
commit58f7dbc0658b3d73816a1bc91b75c2bdac733510 (patch) (side-by-side diff)
tree3d971a9b1a3fd25ca46588112c3a314f971d584f /src/binlog.c
parent23f262e8c6181465347c3bb47644f9d86fcb7432 (diff)
downloadvmod-binlog-58f7dbc0658b3d73816a1bc91b75c2bdac733510.tar.gz
vmod-binlog-58f7dbc0658b3d73816a1bc91b75c2bdac733510.tar.bz2
Fix error checking, add pack tests.
* src/binlog.c (vmod_init): Fix error checking after packcomp. * src/binlogcat.c (catlog): Likewise. * tests/binpack.c (main): Likewise. * src/pack.c (Z_unpacker): Fix output format. (packcomp): allow for whitespace between specifiers. On error set errno and return NULL. * tests/Makefile.am: Add pack.at * tests/testsuite.at: Likewise. * tests/pack.at: New file. * tests/test02.at: Fix name pattern.
Diffstat (limited to 'src/binlog.c') (more/less context) (ignore whitespace changes)
-rw-r--r--src/binlog.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/binlog.c b/src/binlog.c
index 7e88817..765b945 100644
--- a/src/binlog.c
+++ b/src/binlog.c
@@ -220,9 +220,11 @@ vmod_init(struct sess *sp, struct vmod_priv *priv,
AN(conf->dir);
conf->inst_head = packcomp(dataspec, &p);
- AN(conf->inst_head);
- if (*p) {
- binlog_error("cannot compile data format near %s", p);
+ if (!conf->inst_head) {
+ if (errno == EINVAL)
+ binlog_error("cannot compile data format near %s", p);
+ else
+ binlog_error("%s", strerror(errno));
abort();
}
conf->recsize = packsize(conf->inst_head);

Return to:

Send suggestions and report system problems to the System administrator.