Fix statistics gathering algorithm. Start implementing drawing functions.

* src/output.c: New file.
* src/Makefile.am (tagr_SOURCES): Add output.c
* src/graph.c (draw_graph): New function.
* src/main.c (mkfilename): Allow for suffix=NULL
* src/report.c (tr_init): Set queue sizes to exactly the number
of the corresponding samples.
(update_output): New function.
(rebuild): Implement
* src/stat.c (interpolate): Avoid interpolation if time span is
less than the step.
Use queue_put to store the data and always call the overflow
procedure, if supplied.
(overflow): Fix condition.
(compute_avg): New function.
(ovf_monthly, ovf_weekly, ovf_daily): Add verbose diagnostics.
(_convert): Additional argument: overflow function.
(convert_yearly, convert_monthly, convert_weekly): Compute
the average.
Add verbose diagnostics.
(convert_daily): Add verbose diagnostics.
* src/tagr.h (update_output, draw_graph): New protos.

1 files changed, 64 insertions, 14 deletions

diff --git a/src/stat.c b/src/stat.c
index 4c1d434..a7bd2c1 100644
--- a/src/stat.c
+++ b/src/stat.c
@@ -43,7 +43,17 @@ interpolate (queue_t *q,
   time_t next;
+  struct traffic_history th;
 
+  if (now - last_time <= step)
+    {
+      th.inrate = inrate;
+      th.outrate = outrate;
+      verbose (3, "Insert %lu %g %g", next, th.inrate, th.outrate);
+      queue_put (q, &th);
+      if (ovf)
+	ovf (&th, tr, now);
+      return;
+    }
+  
   for (next = last_time + step; next <= now; next += step)
     {
-      struct traffic_history th;
-
       th.inrate  = (inrate - last_rates->inrate) * (next - last_time)
@@ -53,3 +63,4 @@ interpolate (queue_t *q,
       verbose (3, "Insert %lu %g %g", next, th.inrate, th.outrate);
-      if (queue_xchg (q, &th) && ovf)
+      queue_put (q, &th);
+      if (ovf)
 	ovf (&th, tr, now);
@@ -68,3 +79,3 @@ overflow (struct traffic_history *th,
 {
-  if (now - avg->time > step)
+  if (now - avg->time >= step)
     {
@@ -101,4 +112,6 @@ ovf_monthly (struct traffic_history *th, struct traffic_record *tr, time_t now)
 {
+  verbose (2, "begin overflow_monthly %lu %g %g", now, th->inrate, th->outrate);
   overflow (th, tr, now, NULL, &tr->year_avg, &tr->year_hist,
 	    YEAR_COUNT, YEAR_SAMPLE);
+  verbose (2, "end overflow_monthly");
 }
@@ -108,4 +121,6 @@ ovf_weekly (struct traffic_history *th, struct traffic_record *tr, time_t now)
 {
+  verbose (2, "begin overflow_weekly %lu %g %g", now, th->inrate, th->outrate);
   overflow (th, tr, now, ovf_monthly, &tr->month_avg, &tr->month_hist,
 	    MONTH_COUNT, MONTH_SAMPLE);
+  verbose (2, "end overflow_daily");
 }
@@ -115,4 +130,6 @@ ovf_daily (struct traffic_history *th, struct traffic_record *tr, time_t now)
 {
+  verbose (2, "begin overflow_daily %lu %g %g", now, th->inrate, th->outrate);
   overflow (th, tr, now, ovf_weekly, &tr->week_avg, &tr->week_hist,
 	    WEEK_COUNT, WEEK_SAMPLE);
+  verbose (2, "end overflow_daily");
 }
@@ -163,2 +180,21 @@ update_stats (SD *sd, struct traffic_record *tr)
 
+
+static void
+compute_avg (struct avg_acc *avg, queue_t *q, struct last_sample *last)
+{
+  int i, n = queue_count (q);
+  avg->inrate = avg->outrate = 0;
+  avg->count = n;
+
+  for (i = 0; i < n; i++)
+    {
+      struct traffic_history *th = queue_get_ptr (q, i);
+      avg->inrate += th->inrate;
+      avg->outrate += th->outrate;
+    }
+  avg->inrate /= n;
+  avg->outrate /= n;
+  avg->time = last->time;
+}
+
 #define hist_rec last_sample
@@ -166,3 +202,3 @@ update_stats (SD *sd, struct traffic_record *tr)
 static void
-_convert (queue_t *q,
+_convert (queue_t *q, ovf_t ovf,
 	  struct traffic_record *tr, struct hist_rec *hist, size_t count,
@@ -172,3 +208,3 @@ _convert (queue_t *q,
   struct hist_rec *hp;
-  
+
   tr->last.time = hist[count-1].time - sample_interval;
@@ -183,3 +219,3 @@ _convert (queue_t *q,
       outrate = (double) hp->out;
-      
+
       if (interval == 0)
@@ -198,3 +234,3 @@ _convert (queue_t *q,
 		       inrate, outrate,
-		       NULL, tr);
+		       ovf, tr);
 	}
@@ -214,3 +250,3 @@ _convert (queue_t *q,
       tr->last_rates.outrate = outrate;
-    }
+    }  
 }
@@ -220,3 +256,7 @@ convert_yearly (struct traffic_record *tr, struct hist_rec *hp, size_t count)
 {
-  _convert (&tr->year_hist, tr, hp, YEAR_COUNT + 1, YEAR_SAMPLE);
+  verbose (2, "begin convert_yearly");
+  _convert (&tr->year_hist, NULL, tr,
+	    hp, count, YEAR_SAMPLE);
+  compute_avg (&tr->year_avg, &tr->year_hist, &tr->last);
+  verbose (2, "end convert_yearly");
 }
@@ -226,5 +266,9 @@ convert_monthly (struct traffic_record *tr, struct hist_rec *hp, size_t count)
 {
+  verbose (2, "begin convert_monthly");
   if (count > MONTH_COUNT+1)
     convert_yearly (tr, hp + MONTH_COUNT + 1, count - (MONTH_COUNT + 1));
-  _convert (&tr->month_hist, tr, hp, MONTH_COUNT + 1, MONTH_SAMPLE);
+  _convert (&tr->month_hist, ovf_monthly, tr,
+	    hp, MONTH_COUNT + 1, MONTH_SAMPLE);
+  compute_avg (&tr->month_avg, &tr->month_hist, &tr->last);
+  verbose (2, "end convert_monthly");
 }
@@ -234,5 +278,9 @@ convert_weekly (struct traffic_record *tr, struct hist_rec *hp, size_t count)
 {
+  verbose (2, "begin convert_weekly");
   if (count > WEEK_COUNT+1)
     convert_monthly (tr, hp + WEEK_COUNT + 1, count - (WEEK_COUNT + 1));
-  _convert (&tr->week_hist, tr, hp, WEEK_COUNT + 1, WEEK_SAMPLE);
+  _convert (&tr->week_hist, ovf_weekly,
+	    tr, hp, WEEK_COUNT + 1, WEEK_SAMPLE);
+  compute_avg (&tr->week_avg, &tr->week_hist, &tr->last);
+  verbose (2, "end convert_weekly");
 }
@@ -242,5 +290,7 @@ convert_daily (struct traffic_record *tr, struct hist_rec *hp, size_t count)
 {
+  verbose (2, "begin convert_daily");
   if (count > DAY_COUNT+1)
     convert_weekly (tr, hp + DAY_COUNT + 1, count - (DAY_COUNT + 1));
-  _convert (&tr->day_hist, tr, hp, DAY_COUNT + 1, DAY_SAMPLE);
+  _convert (&tr->day_hist, ovf_daily, tr, hp, DAY_COUNT + 1, DAY_SAMPLE);
+  verbose (2, "end convert_daily");
 }
@@ -257,3 +307,3 @@ convert_stats (SD *sd, struct hist_rec *last,
   convert_daily (&tr, hp, count);
-	  
+  
   read_db (sd, &trp);