summaryrefslogtreecommitdiff
path: root/lib/SlackBuild
diff options
context:
space:
mode:
authorSergey Poznyakoff <gray@gnu.org.ua>2019-10-21 12:32:47 +0200
committerSergey Poznyakoff <gray@gnu.org.ua>2019-10-21 12:32:47 +0200
commit6de78ad00952e888fb5e60e77a763016352edcae (patch)
tree2d79dc7f2ef0c994ce488943304e08df4886d3ac /lib/SlackBuild
parent23760946b834b708a807ee1d50678a1e3ee48fa2 (diff)
downloadslackbuilder-6de78ad00952e888fb5e60e77a763016352edcae.tar.gz
slackbuilder-6de78ad00952e888fb5e60e77a763016352edcae.tar.bz2
Minor fixes.
* lib/SlackBuild/Archive.pm (new): Bless the result. * lib/SlackBuild/Archive/Extractor/HTTP.pm (extract): Use $self->logger for error reporting (fixes two leftover uses of error). * lib/SlackBuild/Registry/Record.pm: Remove unnecessary use.
Diffstat (limited to 'lib/SlackBuild')
-rw-r--r--lib/SlackBuild/Archive.pm2
-rw-r--r--lib/SlackBuild/Archive/Extractor/HTTP.pm4
-rw-r--r--lib/SlackBuild/Registry/Record.pm1
3 files changed, 3 insertions, 4 deletions
diff --git a/lib/SlackBuild/Archive.pm b/lib/SlackBuild/Archive.pm
index 3bcc21e..c601975 100644
--- a/lib/SlackBuild/Archive.pm
+++ b/lib/SlackBuild/Archive.pm
@@ -32,7 +32,7 @@ sub DESTROY { }
sub new {
my ($class, $pname) = (shift, shift);
- my $self = $class->SUPER::new(@_);
+ my $self = bless $class->SUPER::new(@_), $class;
$self->{_package_name} = $pname;
return $self;
}
diff --git a/lib/SlackBuild/Archive/Extractor/HTTP.pm b/lib/SlackBuild/Archive/Extractor/HTTP.pm
index 9d1f831..dadcdfc 100644
--- a/lib/SlackBuild/Archive/Extractor/HTTP.pm
+++ b/lib/SlackBuild/Archive/Extractor/HTTP.pm
@@ -47,9 +47,9 @@ sub extract {
for my $diag (@$err) {
my ($file, $message) = %$diag;
if ($file eq '') {
- $self->error("general error: $message");
+ $self->logger->error("general error: $message");
} else {
- $self->error("can't create $file: $message");
+ $self->logger->error("can't create $file: $message");
}
}
return $result;
diff --git a/lib/SlackBuild/Registry/Record.pm b/lib/SlackBuild/Registry/Record.pm
index 4bb4af6..03608e4 100644
--- a/lib/SlackBuild/Registry/Record.pm
+++ b/lib/SlackBuild/Registry/Record.pm
@@ -20,7 +20,6 @@ use warnings;
use Carp;
use SlackBuild::Base qw(package arch build date filename tag suffix vpref);
use SlackBuild::Registry::Version;
-use Scalar::Util qw(blessed);
use List::Regexp;
use File::Basename;

Return to:

Send suggestions and report system problems to the System administrator.