Initial implementation of "startup" components.

These are components that are run at program startup. Starting
other components is delayed until all startup components terminate.
This is similar to SysV "bootwait" components.

Upon termination, startup components are removed from the configuration.
They are not renewed upon configuratuion reload.

* src/comp.c (comp_array_remove): Remove from the depmap as well.
(component_ref_decr): Use comp_array_remove for active components
and plain component_free for inactive ones.
(component_build_depmap): Use comp_array_remove.
(component_config_commit): Special handling for pies_comp_startup
components.
* src/pies.c (modetab): New component modes: "startup" and "shutdown".
(main): Run program_init_startup.
* src/pies.h (pies_comp_mode): New modes: pies_comp_startup and
pies_comp_shutdown.
(program_init_startup): New proto.
* src/progman.c (progman_waiting_p): Return 1 if a startup component
is still running.
(program_init_startup): New function.
(progman_cleanup): Handle pies_comp_startup termination.
* src/socket.c (switch_eids): Avoid unnecessary calls to setegid
and seteuid.

* tests/atlocal.in (auxdir): New variable.
* tests/mailer: Move to tests/aux/
* tests/respawn: Move to tests/aux/
* tests/retcode: Move to tests/aux/
* tests/aux/startup: New auxiliary program.
* tests/redirect.at: Start components from $auxdir.
* tests/respawn.at: Likewise.
* tests/ret-exec.at: Likewise.
* tests/ret-notify.at: Likewise.
* tests/startup.at: New file.
* tests/testsuite.at: Include startup.at
* tests/Makefile.am: Add new tests.

12 files changed, 108 insertions, 9 deletions

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 447104b..b2f2719 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -11,13 +11,19 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with GNU Pies.  If not, see <http://www.gnu.org/licenses/>.
 
-EXTRA_DIST = $(TESTSUITE_AT) testsuite package.m4 respawn retcode mailer
+AUXTOOLS = \
+ aux/respawn\
+ aux/retcode\
+ aux/mailer\
+ aux/startup
+
+EXTRA_DIST = $(TESTSUITE_AT) testsuite package.m4 $(AUXTOOLS)
 DISTCLEANFILES       = atconfig $(check_SCRIPTS)
 MAINTAINERCLEANFILES = Makefile.in $(TESTSUITE)
 
 ## ------------ ##
 ## package.m4.  ##
 ## ------------ ##
@@ -43,12 +49,13 @@ TESTSUITE_AT = \
  control.at\
  cyclic.at\
  respawn.at\
  redirect.at\
  ret-exec.at\
  ret-notify.at\
+ startup.at\
  version.at
 
 TESTSUITE = $(srcdir)/testsuite
 M4=m4
 
 AUTOTEST = $(AUTOM4TE) --language=autotest
diff --git a/tests/atlocal.in b/tests/atlocal.in
index 9069bbd..1992b80 100644
--- a/tests/atlocal.in
+++ b/tests/atlocal.in
@@ -1,10 +1,10 @@
 # @configure_input@                                     -*- shell-script -*-
 # Configurable variable values for GNU Pies test suite.
 # Copyright (C) 2016-2019 Sergey Poznyakoff
 
 PATH=@abs_builddir@:@abs_top_builddir@/src:$srcdir:$PATH
 XFAILFILE=$abs_builddir/.badversion
-
+auxdir="$abs_srcdir/aux"
 trimws() {
     sed 's/[    ][      ]*$//'
 }
diff --git a/tests/mailer b/tests/aux/mailer
index f832ff5..f832ff5 100755
--- a/tests/mailer
+++ b/tests/aux/mailer
diff --git a/tests/respawn b/tests/aux/respawn
index 11d59f6..11d59f6 100755
--- a/tests/respawn
+++ b/tests/aux/respawn
diff --git a/tests/retcode b/tests/aux/retcode
index b827ba9..b827ba9 100755
--- a/tests/retcode
+++ b/tests/aux/retcode
diff --git a/tests/aux/startup b/tests/aux/startup
new file mode 100755
index 0000000..b9d92a3
--- /dev/null
+++ b/tests/aux/startup
@@ -0,0 +1,7 @@
+#!/bin/sh
+dir=${1:?}
+time=${2:?}
+tag=${3:?}
+
+touch $dir/$tag
+sleep $time
diff --git a/tests/redirect.at b/tests/redirect.at
index 9e53ba2..3a8cca7 100644
--- a/tests/redirect.at
+++ b/tests/redirect.at
@@ -21,13 +21,13 @@ PIES_XFAIL_CHECK
 PIES_CONTROL_INIT
 comp_pid_file=$PWD/comp.pid
 outfile=$PWD/out
 cat > pies.conf <<_EOT
 component test {
         mode respawn;
-        command "$abs_srcdir/respawn -tag respawn -append -pid $comp_pid_file";
+        command "$auxdir/respawn -tag respawn -append -pid $comp_pid_file";
         stdout file "$outfile";
 }
 _EOT
 
 pies --config-file control.conf --config-file pies.conf
 
diff --git a/tests/respawn.at b/tests/respawn.at
index 8d72c40..4a8e3a7 100644
--- a/tests/respawn.at
+++ b/tests/respawn.at
@@ -20,13 +20,13 @@ AT_CHECK([
 PIES_XFAIL_CHECK
 PIES_CONTROL_INIT
 comp_pid_file=$PWD/comp.pid
 cat > pies.conf <<_EOT
 component test {
         mode respawn;
-        command "$abs_srcdir/respawn -append -pid $comp_pid_file";
+        command "$auxdir/respawn -append -pid $comp_pid_file";
 }
 _EOT
 
 pies --config-file control.conf --config-file pies.conf
 
 n=0
diff --git a/tests/ret-exec.at b/tests/ret-exec.at
index bf2c1a4..0b3d716 100644
--- a/tests/ret-exec.at
+++ b/tests/ret-exec.at
@@ -23,16 +23,16 @@ PIES_CONTROL_INIT
 comp_pid_file=$PWD/comp.pid
 report_file=$PWD/report
 cat > pies.conf <<_EOT
 component test {
         mode respawn;
         return-code 10 {
-                exec "$abs_srcdir/retcode $report_file";
+                exec "$auxdir/retcode $report_file";
                 action disable;
         }
-        command "$abs_srcdir/respawn -sleep 2 -pid $comp_pid_file -exit 10";
+        command "$auxdir/respawn -sleep 2 -pid $comp_pid_file -exit 10";
 }
 _EOT
 
 >$report_file
 
 pies --config-file control.conf --config-file pies.conf
diff --git a/tests/ret-notify.at b/tests/ret-notify.at
index d1a7f39..a7768aa 100644
--- a/tests/ret-notify.at
+++ b/tests/ret-notify.at
@@ -19,21 +19,21 @@ AT_KEYWORDS([ret-notify])
 
 AT_CHECK([
 PIES_XFAIL_CHECK
 PIES_CONTROL_INIT
 report_file=$PWD/report
 cat > pies.conf <<_EOT
-mailer-program "$abs_srcdir/mailer";
-mailer-command-line "$abs_srcdir/mailer $report_file";
+mailer-program "$auxdir/mailer";
+mailer-command-line "$auxdir/mailer $report_file";
 component test {
         mode respawn;
         return-code 10 {
                 notify root;
                 action disable;
         }
-        command "$abs_srcdir/respawn -sleep 2 -exit 10";
+        command "$auxdir/respawn -sleep 2 -exit 10";
 }
 _EOT
 
 >$report_file
 
 pies --config-file control.conf --config-file pies.conf
diff --git a/tests/startup.at b/tests/startup.at
new file mode 100644
index 0000000..72017ce
--- /dev/null
+++ b/tests/startup.at
@@ -0,0 +1,84 @@
+# This file is part of GNU pies testsuite. -*- Autotest -*-
+# Copyright (C) 2019 Sergey Poznyakoff
+#
+# GNU pies is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3, or (at your option)
+# any later version.
+#
+# GNU pies is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with GNU pies.  If not, see <http://www.gnu.org/licenses/>.
+
+AT_SETUP([Startup components])
+
+AT_CHECK([
+PIES_XFAIL_CHECK
+PIES_CONTROL_INIT
+comp_pid_file=$PWD/comp.pid
+
+cat > pies.conf <<_EOT
+component b1 {
+        mode startup;
+        command "$auxdir/startup $PWD 1 b1";
+}
+
+component b2 {
+        mode startup;
+        command "$auxdir/startup $PWD 2 b2";
+}