Major cleanup

* lib/graypam.h (gray_pam_init)
(gray_raise,gray_malloc,gray_zalloc,gray_calloc)
(gray_realloc,gray_strdup): Remove.
(gray_slist_err,gray_slist_clrerr): New functions.
(gray_slist_append,gray_slist_append_char): Return ssize_t.
(gray_slist_coalesce): Likewise.
(gray_slist_grow_backslash_num)
(gray_slist_grow_backslash): Return int.
(errno_to_pam): New function.
(gray_set_transform_expr): Return int.
* lib/mem.c (gray_raise,gray_malloc,gray_zalloc,gray_calloc)
(gray_realloc,gray_strdup): Remove.
(gray_2nrealloc): Rewrite.
* lib/base64.c: Check return from gray_slist_append_char
* lib/env.c: Check return values from gray_slist functions
* lib/ldappass.c: Likewise.
* lib/slist.c (gray_slist_bucket) <ec>: New member.
(gray_slist_err,gray_slist_clrerr): New functions.
(gray_slist_append,gray_slist_append_char): Return ssize_t.
(gray_slist_coalesce): Likewise.
(gray_slist_grow_backslash_num)
(gray_slist_grow_backslash): Return int.
* lib/transform.c: Use standard memory allocation functions.
* pam_ldaphome/pam_ldaphome.c: Likewise.
* pam_innetgr/pam_innetgr.c: Likewise.
* pam_log/pam_log.c: Likewise.
* pam_regex/pam_regex.c: Likewise.
* pam_sql/pam_mysql.c: Likewise.
* pam_sql/pam_pgsql.c: Likewise.

17 files changed, 788 insertions, 456 deletions

diff --git a/lib/base64.c b/lib/base64.c
index 85b974a..9d0191e 100644
--- a/lib/base64.c
+++ b/lib/base64.c
@@ -51,19 +51,25 @@ gray_base64_decode(gray_slist_t slist, const char *iptr, size_t isize)
                         }
                 }
 
                 /* I have a entire block of data 32 bits get the output
                    data.  */
                 if (i == 4) {
-                        gray_slist_append_char(slist,
-                             (data[0] << 2) | ((data[1] & 0x30) >> 4));
-                        gray_slist_append_char(slist,
-                             ((data[1] & 0xf) << 4) | ((data[2] & 0x3c) >> 2));
-                        gray_slist_append_char(slist,
-                             ((data[2] & 0x3) << 6) | data[3]);
+                        if (gray_slist_append_char(slist,
+                             (data[0] << 2) | ((data[1] & 0x30) >> 4)) != 1)
+                                return -1;
+                        if (gray_slist_append_char(slist,
+                             ((data[1] & 0xf) << 4) | ((data[2] & 0x3c) >> 2))
+                            != 1)
+                                return -1;
+                        if (gray_slist_append_char(slist,
+                            ((data[2] & 0x3) << 6) | data[3]) != 1)
+                                return -1;
                         nbytes += 3 - pad;
-                } else 
+                } else {
+                        errno = EILSEQ;
                         return -1;
+                }
                 i = 0;
         }
         return nbytes;
 }
diff --git a/lib/env.c b/lib/env.c
index 83152e4..b1da177 100644
--- a/lib/env.c
+++ b/lib/env.c
@@ -91,34 +91,45 @@ gray_env_read_tr(const char *file_name, struct gray_env **penv, char **trmap)
         if (!fp) {
                 _pam_log(LOG_ERR, "cannot open configuration file `%s': %s",
                          file_name, strerror (errno));
                 return 1;
         }
 
-        while (p = fgets(buf, sizeof buf, fp)) {
+        while ((p = fgets(buf, sizeof buf, fp))) {
                 int len;
                 struct gray_env *env;
                 
                 line++;
                 while (*p && isspace(*p))
                         p++;
                 len = strlen(p);
                 if (len == 0)
                         continue;
                 if (p[len-1] != '\n') {
-                        if (!slist)
+                        if (!slist) {
                                 slist = gray_slist_create();
-                        gray_slist_append(slist, p, len);
-                        while (p = fgets(buf, sizeof buf, fp)) {
+                                if (!slist) {
+                                        rc = errno;
+                                        break;
+                                }
+                        }
+                        if (gray_slist_append(slist, p, len) != len) {
+                                rc = errno;
+                                break;
+                        }
+                        while ((p = fgets(buf, sizeof buf, fp))) {
                                 len = strlen(p);
                                 gray_slist_append(slist, p, len);
                                 if (p[len - 1] == '\n')
                                         break;
                         } 
-                        gray_slist_append_char(slist, 0);
-                        p = gray_slist_finish(slist);
+                        if (gray_slist_append_char(slist, 0) != 1
+                            || (p = gray_slist_finish(slist)) == NULL) {
+                                rc = errno;
+                                break;
+                        }
                         len = strlen(p);
                 }
 
                 p[len-1] = 0;
                 len = gray_trim_ws(p);
                         
@@ -126,16 +137,25 @@ gray_env_read_tr(const char *file_name, struct gray_env **penv, char **trmap)
                         continue;
 
                 if (p[len-1] == '\\') {
                         int err = 0;
                         
                         /* Collect continuation lines */
-                        if (!slist)
+                        if (!slist) {
                                 slist = gray_slist_create();
+                                if (!slist) {
+                                        rc = errno;
+                                        break;
+                                }
+                        }       
                         do {
-                                gray_slist_append(slist, p, len - 1);
+                                if (gray_slist_append(slist, p, len - 1)
+                                    != len - 1) {
+                                        rc = errno;
+                                        break;
+                                }
                                 p = fgets (buf, sizeof buf, fp);
                                 if (!p)
                                         break;
                                 line++;
                                 len = strlen(p);
                                 if (len == 0)
@@ -147,32 +167,39 @@ gray_env_read_tr(const char *file_name, struct gray_env **penv, char **trmap)
                                         err = 1; 
                                         break;
                                 }
                                 p[len-1] = 0;
                                 len = gray_trim_ws(p);
                         } while (p[len-1] == '\\');
-                        if (len)
-                                gray_slist_append(slist, p, len);
-                        gray_slist_append_char(slist, 0);
-                        p = gray_slist_finish(slist);
+                        if (rc)
+                                break;
+                        if (len) {
+                                if (gray_slist_append(slist, p, len) != len) {
+                                        rc = errno;
+                                        break;
+                                }
+                        }
+                        if (gray_slist_append_char(slist, 0) != 1
+                            || (p = gray_slist_finish(slist)) == NULL) {
+                                rc = errno;
+                                break;
+                        }
                         if (err)
                                 continue;
                 }
                 
                 env = malloc(sizeof *env);
                 if (!env) {
-                        _pam_log(LOG_EMERG, "not enough memory");
-                        rc = 1;
+                        rc = errno;
                         break;
                 }
 
                 env->name = strdup(p);
                 if (!env->name) {
-                        _pam_log(LOG_EMERG, "not enough memory");
+                        rc = errno;
                         free(env);
-                        rc = 1;
                         break;
                 }
 
                 for (p = env->name; *p && !isspace(*p); p++) 
                         ;
                 if (*p)
@@ -192,13 +219,18 @@ gray_env_read_tr(const char *file_name, struct gray_env **penv, char **trmap)
                 env->next = config_env;