Fixes in the testsuite & some minor fixes.

* comsat/comsat.c (main): Use real UID to determine user name. Don't
rely on environment variables.
* maidag/util.c (maidag_error): Re-initialize va_list before reusing it.
* mh/ali.c (ali_print_name_list): Change printing loop to correctly
handle empty lists.
* mh/mh_whatnow.c (quit): Print newline before returning.

* comsat/tests/testsuite.at: Skip tests if run as root.
* maidag/tests/forward.at: Skip test if run as root.
* mh/tests/ali.at: Ignore comment lines in /etc/passwd and /etc/group.
Make sure awk is run with a valid stdin.  Some implementations
(true awk, in particular) try to close stdin even if it is not used and
bail out if unable to do so.
* mh/tests/atlocal.in (mimeflt): Make sure awk is run with a valid
stdin (see above).
* mh/tests/anno.at: Always use semicolon before closing curly brace in
sed expressions.
* mh/tests/mark.at: Likewise.
* mh/tests/pick.at: Likewise.
* testsuite/testsuite.inc: Likewise.
* mh/tests/comp.at: Reflect changes to mh_whatnow.c.
* mh/tests/mhn.at: Don't rely on a particular tar output format.

2 files changed, 4 insertions, 1 deletions

diff --git a/maidag/tests/forward.at b/maidag/tests/forward.at
index bed72d70a..5413d6083 100644
--- a/maidag/tests/forward.at
+++ b/maidag/tests/forward.at
@@ -23,8 +23,9 @@ m4_pushdef([FORWARD_OPTIONS],[dnl
  --set "^forward-file-checks=none"])
 
 AT_CHECK([
+test -w / && AT_SKIP_TEST
 forward=`pwd`/my.forward
-namelist=`sed 's/:.*//;3,$d' /etc/passwd 2>/dev/null`
+namelist=`sed '/^#/d;s/:.*//' /etc/passwd | sed '3,$d'`
 test -n "$namelist" || AT_SKIP_TEST
 
 cat > my.forward <<EOT
diff --git a/maidag/util.c b/maidag/util.c
index 406488203..8d46dcc14 100644
--- a/maidag/util.c
+++ b/maidag/util.c
@@ -73,6 +73,8 @@ maidag_error (const char *fmt, ...)
       vfprintf (stderr, fmt, ap);
       fputc ('\n', stderr);
     }
+  va_end (ap);
+  va_start (ap, fmt);
   mu_verror (fmt, ap);
   va_end (ap);
 }