summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ChangeLog7
-rw-r--r--lib/gc-gnulib.c3
-rw-r--r--lib/gc-libgcrypt.c4
3 files changed, 13 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 90b0377f4c..54802599bc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2019-08-24 Bruno Haible <bruno@clisp.org>
+ crypto/gc-md2: Optimize and clarify code.
+ * lib/gc-gnulib.c (gc_hash_open): Comment out md2_init_ctx invocation.
+ * lib/gc-libgcrypt.c (gc_hash_open): Clarify why md2_init_ctx invocation
+ is not needed.
+
+2019-08-24 Bruno Haible <bruno@clisp.org>
+
crypto/gc-md2: Add comment.
* lib/gc-libgcrypt.c: Add comment.
diff --git a/lib/gc-gnulib.c b/lib/gc-gnulib.c
index 62aa50a2ec..6fcb4a1c87 100644
--- a/lib/gc-gnulib.c
+++ b/lib/gc-gnulib.c
@@ -646,7 +646,8 @@ gc_hash_open (Gc_hash hash, Gc_hash_mode mode, gc_hash_handle * outhandle)
{
#if GNULIB_GC_MD2
case GC_MD2:
- md2_init_ctx (&ctx->md2Context);
+ /* Not needed, because ctx is already zero-initialized. */
+ /*md2_init_ctx (&ctx->md2Context);*/
break;
#endif
diff --git a/lib/gc-libgcrypt.c b/lib/gc-libgcrypt.c
index 6c95712bf1..fbfd0a138f 100644
--- a/lib/gc-libgcrypt.c
+++ b/lib/gc-libgcrypt.c
@@ -270,9 +270,13 @@ gc_hash_open (Gc_hash hash, Gc_hash_mode mode, gc_hash_handle * outhandle)
switch (hash)
{
+#if GNULIB_GC_MD2
case GC_MD2:
+ /* Not needed, because ctx is already zero-initialized. */
+ /*md2_init_ctx (&ctx->md2Context);*/
gcryalg = GCRY_MD_NONE;
break;
+#endif
case GC_MD4:
gcryalg = GCRY_MD_MD4;

Return to:

Send suggestions and report system problems to the System administrator.