diff options
| author | Paul Eggert <eggert@cs.ucla.edu> | 2020-06-01 17:57:27 -0700 |
|---|---|---|
| committer | Paul Eggert <eggert@cs.ucla.edu> | 2020-06-01 17:57:40 -0700 |
| commit | c0f267c9308e3bbaec040d2b1f4e0ff0fe39e5dd (patch) | |
| tree | 5b9e62b6afd4568338210e5a8e022a1ac8e479e4 | |
| parent | a6ca54ccd9565b73ad998826f6791581a86b4607 (diff) | |
| download | gnulib-c0f267c9308e3bbaec040d2b1f4e0ff0fe39e5dd.tar.gz gnulib-c0f267c9308e3bbaec040d2b1f4e0ff0fe39e5dd.tar.bz2 | |
getloadavg: fix double-increment bug
* lib/getloadavg.c (getloadavg): Fix double-increment typo on
Linux without glibc, Android, Cygwin. This fixes a bug I
introduced in 2011-02-08T20:23:29Z!eggert@cs.ucla.edu.
Problem and fix reported by Semen Verchenko in:
https://lists.gnu.org/r/bug-gnulib/2020-06/msg00007.html
| -rw-r--r-- | ChangeLog | 7 | ||||
| -rw-r--r-- | lib/getloadavg.c | 2 |
2 files changed, 8 insertions, 1 deletions
@@ -1,5 +1,12 @@ 2020-06-01 Paul Eggert <eggert@cs.ucla.edu> + getloadavg: fix double-increment bug + * lib/getloadavg.c (getloadavg): Fix double-increment typo on + Linux without glibc, Android, Cygwin. This fixes a bug I + introduced in 2011-02-08T20:23:29Z!eggert@cs.ucla.edu. + Problem and fix reported by Semen Verchenko in: + https://lists.gnu.org/r/bug-gnulib/2020-06/msg00007.html + tempname: use getrandom, not getentropy This removes a dependency, as getentropy depends on getrandom. * lib/tempname.c: Include sys/random.h instead of unistd.h. diff --git a/lib/getloadavg.c b/lib/getloadavg.c index 61307d3772..aeb7070cc7 100644 --- a/lib/getloadavg.c +++ b/lib/getloadavg.c @@ -550,7 +550,7 @@ getloadavg (double loadavg[], int nelem) for (ptr++; '0' <= *ptr && *ptr <= '9'; ptr++) numerator = 10 * numerator + (*ptr - '0'), denominator *= 10; - loadavg[elem++] = numerator / denominator; + loadavg[elem] = numerator / denominator; } return elem; |