authorSergey Poznyakoff <>2018-08-19 06:50:22 (GMT)
committer Sergey Poznyakoff <>2018-08-19 06:56:14 (GMT)
commit64ef7e827406f91d31bffdcad9f4b8aaad1f874c (patch) (side-by-side diff)
parent4e23fa7b90b56408d480ba8c7556b190757ea2c7 (diff)
Fix directory entry validation.
Bug reported by Miroslav Lichvar and Marek Skalick√Ĺ * src/bucket.c (gdbm_dir_entry_valid_p): Fix lower limit for the allowed bucket address. Initial allocation of second block for the directory can be eventually returned to the available list when the directory is expanded during bucket splitting.
Diffstat (more/less context) (ignore whitespace changes)
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bucket.c b/src/bucket.c
index 0597965..3d267e2 100644
--- a/src/bucket.c
+++ b/src/bucket.c
@@ -51,13 +51,13 @@ _gdbm_new_bucket (GDBM_FILE dbf, hash_bucket *bucket, int bits)
attempt to read a block at that offset. */
gdbm_dir_entry_valid_p (GDBM_FILE dbf, int dir_index)
return dir_index >= 0
&& dir_index < GDBM_DIR_COUNT (dbf)
- && dbf->dir[dir_index] >= 2*dbf->header->block_size;
+ && dbf->dir[dir_index] >= dbf->header->block_size;
/* Find a bucket for DBF that is pointed to by the bucket directory from
location DIR_INDEX. The bucket cache is first checked to see if it
is already in memory. If not, a bucket may be tossed to read the new
bucket. On success, the requested bucket becomes the "current" bucket

Return to:

Send suggestions and report system problems to the System administrator.