summaryrefslogtreecommitdiffabout
authorSergey Poznyakoff <gray@gnu.org.ua>2020-01-22 08:16:15 (GMT)
committer Sergey Poznyakoff <gray@gnu.org.ua>2020-01-22 08:16:15 (GMT)
commit68be041dd11573aff08847748456040b9ef3f0b4 (patch) (side-by-side diff)
tree62ef33804f0bafd8102415bbb6e31a528c35b560
parent59376e36716be20a2a517231ef597b3687c45b0e (diff)
downloadfile-backup-68be041dd11573aff08847748456040b9ef3f0b4.tar.gz
file-backup-68be041dd11573aff08847748456040b9ef3f0b4.tar.bz2
Bugfixes
* lib/File/BackupCopy.pm (backup_copy_internal): Clear unlink_on_destroy on success. * t/02auto.t: close FH to avoid spurious warnings * t/TestBackup.pm: Fix incorrect range.
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--lib/File/BackupCopy.pm1
-rw-r--r--t/02auto.t1
-rw-r--r--t/TestBackup.pm2
3 files changed, 3 insertions, 1 deletions
diff --git a/lib/File/BackupCopy.pm b/lib/File/BackupCopy.pm
index b762e03..226e8ce 100644
--- a/lib/File/BackupCopy.pm
+++ b/lib/File/BackupCopy.pm
@@ -157,6 +157,7 @@ sub backup_copy_internal {
unless (rename($fh->filename, $backup_name)) {
return _backup_copy_error("can't rename temporary file to $backup_name: $!");
}
+ $fh->unlink_on_destroy(0);
return $backup_name;
}
diff --git a/t/02auto.t b/t/02auto.t
index 0a01d84..61b24ed 100644
--- a/t/02auto.t
+++ b/t/02auto.t
@@ -30,6 +30,7 @@ ok($name, File::Spec->catfile('subdir','a~'));
fileok('a', $name);
ok(open(FH, '>', File::Spec->catfile('subdir','a.~1~')));
+close FH;
$name = backup_copy_auto('a', dir => 'subdir');
ok($name, File::Spec->catfile('subdir','a.~2~'));
fileok('a', $name);
diff --git a/t/TestBackup.pm b/t/TestBackup.pm
index 0679776..72e5925 100644
--- a/t/TestBackup.pm
+++ b/t/TestBackup.pm
@@ -26,7 +26,7 @@ sub makefile {
while ($size) {
my $n = @pattern;
$n = $size if $n > $size;
- syswrite(FH, join('',@pattern[0..$n])) or
+ syswrite(FH, join('',@pattern[0..$n-1])) or
croak "write error creating $file: $!";
$size -= $n;
}

Return to:

Send suggestions and report system problems to the System administrator.